Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs unification 1 #19631

Merged
merged 25 commits into from Apr 29, 2024
Merged

Docs unification 1 #19631

merged 25 commits into from Apr 29, 2024

Conversation

EmreKendirli
Copy link
Contributor

TODO: Abp docs broken links and image path fixed

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@hikalkan hikalkan added this to the 8.3-preview milestone Apr 29, 2024
@realLiangshiwei
Copy link
Member

Hi @EmreKendirli
There are two folders with the same name; I guess we should keep the lowercase folders; could you check it? Thanks.

image

And some files have not been changed. Is this expected?
image

@EmreKendirli
Copy link
Contributor Author

Hi @realLiangshiwei ,
Yes, I must have missed it, lower case files should be removed.
Some files were expected not to be changed. Other files were edited in this pull request #19630

@realLiangshiwei
Copy link
Member

Seems good, When you solve the folder name problem, I can merge this
#19631 (comment)

@EmreKendirli
Copy link
Contributor Author

The folders were divided between two people. Someone else was going to make the folders you mentioned. @realLiangshiwei

@realLiangshiwei
Copy link
Member

realLiangshiwei commented Apr 29, 2024 •
edited

The folders were divided between two people. Someone else was going to make the folders you mentioned.

I meant the folder name case.

image

@EnesDONER EnesDONER mentioned this pull request Apr 29, 2024
Merged
@EnesDONER
Copy link
Contributor

Hi @realLiangshiwei, this pull request does not change all links. #19630 needs to be merged with this pull request. Merging with this will eliminate the problems.

@EmreKendirli
Copy link
Contributor Author

The folders were divided between two people. Someone else was going to make the folders you mentioned.

I meant the folder name case.

image

I got it done. @realLiangshiwei

@realLiangshiwei realLiangshiwei self-requested a review April 29, 2024 10:47
@realLiangshiwei realLiangshiwei merged commit 0c96d2c into abpframework:docs-unification-1 Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realLiangshiwei realLiangshiwei realLiangshiwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.3-preview
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@EmreKendirli @CLAassistant @realLiangshiwei @EnesDONER @hikalkan