Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update datatables.net to 2.0.2. #19340

Merged
merged 4 commits into from May 2, 2024
Merged

Update datatables.net to 2.0.2. #19340

merged 4 commits into from May 2, 2024

Conversation

maliming
Copy link
Member

@maliming maliming commented Mar 18, 2024

The milestone is 8.3, we can review and test it later.

Resolve #19323

How to test:

  1. Add resolutions section to packages.json and restore packages.
"resolutions": {
  "datatables.net": "^2.0.2",
  "datatables.net-bs5": "^2.0.2"
}
  1. Update the abp.resourcemapping.js on the template web project.
module.exports = {
    aliases: {

    },
    clean: [

    ],
    mappings: {
        "@node_modules/datatables.net/js/dataTables.min.js": "@libs/datatables.net/js/"
    }
};
  1. Run web project and check if all datatables work.

@maliming maliming added this to the 8.2-preview milestone Mar 18, 2024
@maliming maliming marked this pull request as ready for review March 19, 2024 02:03
@maliming maliming modified the milestones: 8.2-preview, 8.3-preview Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 51.56%. Comparing base (5333e1f) to head (06e4cfd).
Report is 228 commits behind head on dev.

❗ Current head 06e4cfd differs from pull request most recent head 78d11f2. Consider uploading reports for the commit 78d11f2 to get more accurate results

Files Patch % Lines
...es/DatatablesNet/DatatablesNetScriptContributor.cs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #19340      +/-   ##
==========================================
- Coverage   51.66%   51.56%   -0.11%     
==========================================
  Files        3110     3098      -12     
  Lines       99278    98538     -740     
  Branches     7933     7878      -55     
==========================================
- Hits        51291    50810     -481     
+ Misses      46421    46163     -258     
+ Partials     1566     1565       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliming maliming merged commit 1abebbe into dev May 2, 2024
3 checks passed
@maliming maliming deleted the datatables-2 branch May 2, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Datatables 2.x
2 participants