Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor modules' local user synchronization #17699

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

gdlcf88
Copy link
Contributor

@gdlcf88 gdlcf88 commented Sep 21, 2023

Resolve #17167

@gdlcf88 gdlcf88 marked this pull request as ready for review September 21, 2023 14:07
@maliming maliming marked this pull request as draft September 22, 2023 02:28
@maliming maliming marked this pull request as ready for review September 22, 2023 06:54
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (3d8fda7) 53.49% compared to head (bc8d3a6) 53.49%.
Report is 1234 commits behind head on dev.

Files Patch % Lines
...p.Users.Domain/Volo/Abp/Users/UserLookupService.cs 13.51% 32 Missing ⚠️
...p.Users.Domain/Volo/Abp/Users/AbpUserExtensions.cs 5.88% 16 Missing ⚠️
...it.Domain/Volo/CmsKit/Users/CmsUserSynchronizer.cs 0.00% 11 Missing ⚠️
...o.Abp.Users.Abstractions/Volo/Abp/Users/UserEto.cs 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #17699      +/-   ##
==========================================
- Coverage   53.49%   53.49%   -0.01%     
==========================================
  Files        3037     3037              
  Lines       94917    94947      +30     
==========================================
+ Hits        50779    50795      +16     
- Misses      44138    44152      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UserEto is better to implement IHasEntityVersion
1 participant