Do not auto discover generic event handlers

[PMExtra]

Description

Adding a GenericTypeDefinition (a generic type without arguments) to the AbpLocalEventBusOptions.Handlers or AbpDistributedEventBusOptions.Handlers makes no sense.

It cannot be determined which event should be subscribed.

And it makes KafkaDistributedEventBus broken:

Volo.Abp.AbpInitializationException: An error occurred during the initialize Volo.Abp.Modularity.OnApplicationInitializationModuleLifecycleContributor phase of the module Volo.Abp.EventBus.Kafka.AbpEventBusKafkaModule, Volo.Abp.EventBus.Kafka, Version=7.2.1.0, Culture=neutral, PublicKeyToken=null: Value cannot be null. (Parameter 'key'). See the inner exception for details.
 ---> System.ArgumentNullException: Value cannot be null. (Parameter 'key')
   at System.ThrowHelper.ThrowArgumentNullException(String name)
   at System.Collections.Concurrent.ConcurrentDictionary`2.set_Item(TKey key, TValue value)
   at Volo.Abp.EventBus.Kafka.KafkaDistributedEventBus.<GetOrCreateHandlerFactories>b__38_0(Type type)
   at System.Collections.Concurrent.ConcurrentDictionary`2.GetOrAdd(TKey key, Func`2 valueFactory)
   at Volo.Abp.EventBus.Kafka.KafkaDistributedEventBus.GetOrCreateHandlerFactories(Type eventType)
   at Volo.Abp.EventBus.Kafka.KafkaDistributedEventBus.Subscribe(Type eventType, IEventHandlerFactory factory)
   at Volo.Abp.EventBus.EventBusBase.SubscribeHandlers(ITypeList`1 handlers)
   at Volo.Abp.EventBus.Kafka.KafkaDistributedEventBus.Initialize()
   at Volo.Abp.EventBus.Kafka.AbpEventBusKafkaModule.OnApplicationInitialization(ApplicationInitializationContext context)
   at Volo.Abp.Modularity.AbpModule.OnApplicationInitializationAsync(ApplicationInitializationContext context)
   at Volo.Abp.Modularity.OnApplicationInitializationModuleLifecycleContributor.InitializeAsync(ApplicationInitializationContext context, IAbpModule module)
   at Volo.Abp.Modularity.ModuleManager.InitializeModulesAsync(ApplicationInitializationContext context)

Checklist

• I fully tested it as developer / designer and created unit / integration tests
• I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

Take the MyGenericDistributedEventHandler class to your tests with Kafka Event Bus, then register it to your service collection like EventBusTestModule.

It would be broken without this patch.

[CLAassistant]

All committers have signed the CLA.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.29%. Comparing base (72d69d3) to head (e1e0342).
Report is 2959 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #17465      +/-   ##
==========================================
- Coverage   53.34%   53.29%   -0.05%     
==========================================
  Files        3024     3024              
  Lines       94357    94362       +5     
==========================================
- Hits        50334    50292      -42     
- Misses      44023    44070      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[maliming]

Is there any actual reason to use such a class?

public class MyGenericDistributedEventHandler<TEvent> : IDistributedEventHandler<TEvent>

[PMExtra]

Yes, we have an options to set which events should be handled by this handler.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[PMExtra]

This issue is still unresolved. Waiting for the staff's response.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[PMExtra]

@maliming

[maliming]

https://github.com/abpframework/abp/pull/17465/files#r1305402874

[PMExtra]

@maliming 非要在单元测试里复现的话，那需要ABP先提供一个KafkaEventBus的单元测试