Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserEto is better to implement IHasEntityVersion #17167

Open
1 task done
gdlcf88 opened this issue Jul 22, 2023 · 4 comments · May be fixed by #17699
Open
1 task done

UserEto is better to implement IHasEntityVersion #17167

gdlcf88 opened this issue Jul 22, 2023 · 4 comments · May be fixed by #17699
Labels
feature inactive

Comments

@gdlcf88
Copy link
Contributor

gdlcf88 commented Jul 22, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

No response

Describe the solution you'd like

After #16495 is merged, the UserEto is better to implement IHasEntityVersion. So that we can remove user synchronizers (such as BlogUserSynchronizer) and use the ABP Entity Synchronizer.

Additional context

No response
@gterdem
Copy link
Member

gterdem commented Sep 8, 2023

@maliming This will be a breaking change but i think doing it in v8.0.0 would be reasonable. What do you think?

@maliming
Copy link
Member

I agree with you. @gdlcf88 Will you open the PR?

gdlcf88 added a commit to gdlcf88/abp that referenced this issue Sep 21, 2023
@gdlcf88
Refactor modules' local user synchronization
031525f 
Resolve abpframework#17167
@gdlcf88 gdlcf88 linked a pull request Sep 21, 2023 that will close this issue
Open
@gdlcf88
Copy link
Contributor Author

gdlcf88 commented Sep 21, 2023

This is more complicated than I thought and seems to require a lot of unit test cases. Please review these changes first, as I'm not sure if they are in line with the design.

@stale Stale
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor modules' local user synchronization gdlcf88/abp
3 participants
@gterdem @maliming @gdlcf88