Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

[Fixes #143] Replace deprecated twoway with memchr #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ safemem = { version = "0.3", optional = true }
tempfile = "3"
clippy = { version = ">=0.0, <0.1", optional = true}

#Server Dependencies
# Server Dependencies
buf_redux = { version = "0.8", optional = true, default-features = false }
httparse = { version = "1.2", optional = true }
twoway = { version = "0.1", optional = true }
memchr = { version = "2.5", optional = true }
quick-error = { version = "1.2", optional = true }

# Optional Integrations
Expand All @@ -48,7 +48,7 @@ env_logger = "0.5"
[features]
client = []
default = ["client", "hyper", "iron", "mock", "nickel", "server", "tiny_http"]
server = ["buf_redux", "httparse", "quick-error", "safemem", "twoway"]
server = ["buf_redux", "httparse", "quick-error", "safemem", "memchr"]
mock = []
nightly = []
bench = []
Expand Down
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,9 @@ to `std::io::BufReader`.)

Fast, zero-copy HTTP header parsing, used to read field headers in `multipart/form-data` request bodies.

### [twoway ![](https://img.shields.io/crates/v/twoway.svg)](https://crates.io/crates/twoway)
### [memchr ![](https://img.shields.io/crates/v/memchr.svg)](https://crates.io/crates/memchr)

Fast string and byte-string search. Used to find boundaries in the request body. Uses SIMD acceleration
when possible.
The library provides heavily optimized routines for string search primitives.

## License

Expand Down
4 changes: 2 additions & 2 deletions src/server/boundary.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use ::safemem;

use super::buf_redux::BufReader;
use super::buf_redux::policy::MinBuffered;
use super::twoway;
use super::memchr::memmem;

use std::cmp;
use std::borrow::Borrow;
Expand Down Expand Up @@ -198,7 +198,7 @@ impl<R> BoundaryReader<R> where R: Read {

/// Find the boundary occurrence or the highest length to safely yield
fn find_boundary(buf: &[u8], boundary: &[u8]) -> Result<usize, usize> {
if let Some(idx) = twoway::find_bytes(buf, boundary) {
if let Some(idx) = memmem::find(buf, boundary) {
return Ok(idx);
}

Expand Down
2 changes: 1 addition & 1 deletion src/server/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

pub extern crate buf_redux;
extern crate httparse;
extern crate twoway;
extern crate memchr;

use std::borrow::Borrow;
use std::io::prelude::*;
Expand Down