Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Allow creating irc connections from Read+Write #164

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kpcyrd
Copy link
Contributor

@kpcyrd kpcyrd commented Nov 6, 2018

Resolves #162 (eventually)

I'm not sure how complete that implementation is at this point, since you know the codebase a lot better than I do you might be able to give some pointers.

So far it seems I can just ignore all options that are not relevant for me, but I'm wondering if it's possible to disable reconnects and handle them myself. A reconnect attempt would likely error out since config.server is None.

As a note, this is somewhat related to #151

@aatxe
Copy link
Owner

aatxe commented Dec 14, 2018

Hi @kpcyrd!

Thank you for the pull request, and I'm sorry for the delay in response! 😄

At first glance, this looks like it should work, but I'd like to see some more testing.

If possible, can you produce unit tests that use this new Generic connection type? You might be able to use Vec or something similar as a stream here, and then inspect it at the end (which is roughly how the Mock variant works). If not, I'd at least like to have an example program using it both for documentation purposes and sort of integration testing the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants