feat: Add output filename or dir to generate #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowan-gud
changed the title
|
@rowan-gud , @a-h , any updates on moving through with this change? |
|
Hi @a-h sorry I dropped off the face of the earth haha. It looks like a couple things happened, it looks like #628 addresses the underlying issue that I brought up of not being able to change the output of the generation. It looks like based on the conversation in #735 we may still want the option to output to a file / directory as well. I'm going to close this PR since I think it's pretty outdated at this point but I would be happy to work together with @jespert to come up with a solution for adding a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my preliminary understanding of the codebase this could be a potential solution to issue-197 . Please let me know what should be changed or done better!