Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Production ready Prompt Service dockerfile & Handling timeout exceptions #347

Merged
merged 5 commits into from
May 25, 2024

Conversation

harini-venkataraman
Copy link
Contributor

@harini-venkataraman harini-venkataraman commented May 23, 2024

What

This PR adds an entrypoint script to Prompt service.
...

Why

Prompt service is running with default settings and it is not scalable with increasing requests.
...

How

Adding threads and increasing timeout.
...

Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

No, the prompt service is started and is up and running.
...

Database Migrations

Not applicable.
...

Env Config

Not applicable
...

Relevant Docs

Related Issues or PRs

https://zipstack.atlassian.net/browse/UN-1265
...

Dependencies Versions

Notes on Testing

Screenshots

image

Checklist

I have read and understood the Contribution Guidelines.

@harini-venkataraman harini-venkataraman marked this pull request as ready for review May 23, 2024 14:56
@harini-venkataraman harini-venkataraman requested review from ritwik-g, a team and kirtimanmishrazipstack and removed request for a team May 23, 2024 14:58
Copy link
Contributor

@ritwik-g ritwik-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harini-venkataraman please raise a PR in cloud platform with entry point file for this. There use the production config. You can refer backend entry point there

Copy link

sonarcloud bot commented May 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nehabagdia nehabagdia merged commit 72a860a into main May 25, 2024
4 checks passed
@nehabagdia nehabagdia deleted the fix/prompt-service-entrypoint branch May 25, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants