Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.9.0] Accounts: hardware wallet / external signer support + batching #2127

Merged
merged 12 commits into from
Apr 23, 2024

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Apr 17, 2024

Description

Related issues: ZEUS-942, ZEUS-1121

This PR adds ability to import external accounts to the LND interfaces (embedded, REST, and LNC). With these external accounts, you can send and receive on-chain transactions, craft channel opens with airgapped funds, and observe balances in a watch-only manner.

This PR also adds the ability to send batch txs and batch open channels.

Lastly, this PR also adds the ability for generating and scanning animated QRs using both BC-ur and BBQr formats.

It has been tested against the Coldcard Q and SeedSigner hardware devices. It should work with any external signer, as Coldcard PSBT validation is the strictest we've seen so far - but no promises.

Replaces #726, which was opened almost 2 and a half years ago!

Constraints:

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (c-lightning-REST)
  • LndHub
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.9.0 milestone Apr 17, 2024
@kaloudis kaloudis mentioned this pull request Apr 17, 2024
@kaloudis kaloudis changed the title Accounts: hardware wallet / external signer support [v0.9.0] Accounts: hardware wallet / external signer support Apr 23, 2024
@kaloudis kaloudis changed the base branch from master to v0-9-0-branch April 23, 2024 01:12
@kaloudis kaloudis changed the title [v0.9.0] Accounts: hardware wallet / external signer support [v0.9.0] Accounts: hardware wallet / external signer support + batching Apr 23, 2024
@kaloudis kaloudis merged commit 5c5e4cc into ZeusLN:v0-9-0-branch Apr 23, 2024
3 checks passed
@kaloudis kaloudis deleted the hwi branch April 23, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant