[bookworm] Return auth cookie valid for whole main domain. #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orhtej2
changed the title
2 tasks
I think it's to prepare the move to "one domain, one portal" down the line. (https://forum.yunohost.org/t/call-for-feedback-sso-portal-in-multi-domain-context-how-should-it-work/7491) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
If app specify private path it's impossible to access as
yunohost.portalcookie is not forwarded when app is installed on subdomain.Solution
Return cookie valid for
.domain.tld, just like oldSSOWatdid. Come to think about it we should return cookies valid for all domains?PR Status
It worked once.
How to test
Install LimeSurvey from https://github.com/orhtej2/limesurvey_ynh/tree/patch-2 and see if you can access admin.