[enh] Implement 'yunohost log show last' to display the last log file.

[Abperron]

Resolves YunoHost/issues#2047

The problem

As said in YunoHost/issues#2047, yunohost log show is annoying to use because it's required to know the name of the log file.

Solution

The path argument can be replaced by the "magic" keywords last or last-X to display the last or last but X log file (last-0 means last).

log_show now uses the log_list function.

We didn't internationalize the error message if 'X' is too big because it can only appear in the CLI for now, which seems not internationalized either.

PR Status

Done.

How to test

• Run yunohost log show last or yunohost log show last-1.

[Psycojoker]

I don't understand why you aren't using CLI arguments like "--last/-l" and "--number-of-logs/-N" and parsing a string instead, is there a reason for that?

[manor-tile]

We did this because the issue seemed to propose to do this, and it makes sense because the path argument already means "which log file to show?".

I also think it's easier to read, remember and write, compare:

yunohost log show last-1
yunohost log show -l -N 1
yunohost log show --last --number-of-logs 1

On the other side using dedicated CLI arguments as your propose is more standard and avoids using a regex, so there is a trade-off between our solution and yours and we are not sure about which is best.

[manor-tile]

Would an alternative pull request using dedicated CLI arguments be appreciated? Is there something else we could do to enhance our pull request or resolve the related issue ?

[kay0u]

Sorry about the response time, we just need volunteers to test the code and press the green button 🙂

[alexAubin]

Cheers and sorry for the delay, bonus point for the regex thing, the named "position" group thing is neat 👍 👌