Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger hooks when adding or removing user into group #1696

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

grosmanal
Copy link

The problem

The post_app_addaccess and post_app_removeaccess are not triggered when adding or removing a user to / from a group with the commands yunohost user group add and yunohost user group remove

Solution

Add a hook_callback call in the appropriate function.

PR Status

To be tested

How to test

  • install a app with post_app_addaccess and post_app_removeaccess hooks
  • add a user into a group
  • => post_app_addaccess hook is called
  • remove a user from a group
  • => post_app_removeaccess hook is called

This PR is related to YunoHost/issues#2213

Copy link
Contributor

@Tagadda Tagadda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we can wait bookworm to merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants