Add definitions.json changes to xrpl package #2214
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
JST5000
commented
Jan 17, 2024
| const tx = typeof transaction === 'string' ? decode(transaction) : transaction | ||
| function isSigned<T extends BaseTransaction = Transaction>( | ||
| transaction: T | string, | ||
| definitions?: InstanceType<typeof XrplDefinitionsBase>, |
There was a problem hiding this comment.
Should not be optional since this directly uses decode, so we should specify our default one layer above the binary codec across the board.
JST5000
commented
Jan 17, 2024
| transaction: Transaction | string, | ||
| function getLastLedgerSequence<T extends BaseTransaction = Transaction>( | ||
| transaction: T | string, | ||
| definitions?: InstanceType<typeof XrplDefinitionsBase>, |
JST5000
commented
Jan 17, 2024
| const tx = typeof transaction === 'string' ? decode(transaction) : transaction | ||
| function isAccountDelete<T extends BaseTransaction = Transaction>( | ||
| transaction: T | string, | ||
| definitions?: InstanceType<typeof XrplDefinitionsBase>, |
There was a problem hiding this comment.
Nevermind (and for all above) - I think it makes the most sense to just have encode and decode be the only functions with default value of DEFAULT_DEFINITIONS.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The user interface for defining custom definitions needs more work, so I split up #2127 to focus on the binary-codec, with this one focusing on the interface.
Context of Change
With sidechains and many amendments being worked on, we need a better way to define which types & transactions we're able to serialize/deserialize.
Type of Change
Before / After
Test Plan
CI Passes
Future Tasks
server_definitions