-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Amendment XLS-34d #2184
Open
dangell7
wants to merge
102
commits into
XRPLF:main
Choose a base branch
from
Transia-RnD:iouescrow
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
reviewed
Feb 15, 2023
mvadari
reviewed
Feb 15, 2023
mvadari
reviewed
Feb 15, 2023
mvadari
reviewed
Feb 15, 2023
mvadari
reviewed
Feb 15, 2023
mvadari
reviewed
Feb 15, 2023
lgtm |
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Adding functionality for XLS-34d Amendment
Context of Change
Amount
- string -> AmountAmount
- string -> AmountI added an Issue function on the setup client. I don't like that it runs for each and can move that functionality to the specific test if necessary. Or in the C# client, I issue inside the individual test and will like to refactor that to match.
Type of Change
Before / After
XRP ONLY for Payment Channel & Escrow / IOU/XRP for Payment Channel & Escrow
Test Plan
Please review the tests and let me know if you see more. There are much more tests in the rippled library. We can definitely adopt them.
I would like to discuss the gateway setup and having access to an issued token in each test suite.