Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add More Crossing Limits Testing #5020

Closed
wants to merge 4 commits into from

Conversation

dangell7
Copy link
Collaborator

@dangell7 dangell7 commented May 20, 2024

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.1%. Comparing base (d5e5c3c) to head (01e028a).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5020   +/-   ##
=======================================
  Coverage     71.1%   71.1%           
=======================================
  Files          796     796           
  Lines        66997   66997           
  Branches     10982   10969   -13     
=======================================
+ Hits         47635   47655   +20     
+ Misses       19362   19342   -20     

see 3 files with indirect coverage changes

Impacted file tree graph

@dangell7 dangell7 closed this May 29, 2024
@dangell7 dangell7 deleted the test-cross-limits branch May 29, 2024 19:33
@dangell7 dangell7 restored the test-cross-limits branch May 29, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants