test: Check for some unlikely null dereferences in tests #5004
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5004 +/- ##
=========================================
- Coverage 70.9% 70.9% -0.0%
=========================================
Files 796 796
Lines 66792 66792
Branches 11002 11000 -2
=========================================
- Hits 47379 47372 -7
- Misses 19413 19420 +7 see 3 files with indirect coverage changes |
ckeshava
reviewed
Apr 26, 2024
| @@ -51,7 +51,9 @@ void | |||
| nflags::operator()(Env& env) const | |||
| { | |||
| auto const sle = env.le(account_); | |||
| if (sle->isFieldPresent(sfFlags)) | |||
| if (!sle) | |||
There was a problem hiding this comment.
Before line 44 (above), for the sake of consistency, we need to introduce a similar check
ckeshava
reviewed
Apr 26, 2024
| @@ -51,7 +51,9 @@ void | |||
| nflags::operator()(Env& env) const | |||
| { | |||
| auto const sle = env.le(account_); | |||
There was a problem hiding this comment.
The data members flags::account_ and nflags::account_ always hold a valid instance of the Account class. These data members are not pointers or std::optional values.
Hence, env.le(account_) must always exist, isn't it? Are you envisioning a future modification to these flags and nflags classes, due to which a null pointer might be returned here?
* upstream/develop: Set version to 2.2.0-rc1
* upstream/develop: Remove flow assert: (5009) Update list of maintainers: (4984)
* upstream/develop: Add external directory to Conan recipe's exports (5006) Add missing includes (5011)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
I stumbled upon these couple of places where test code could, but is very unlikely to, dereference a null pointer. I added a simple check to each of them.
Context of Change
This was a random find.
Even though these changes are tiny, I don't think they are insignificant enough to be considered "trivial", so I'm requesting two reviews.
Type of Change
Before / After
There should be no observable change, as tests aren't currently likely / able to get a null value.
Future Tasks
Maybe there are more of these?