Plugin Directory: Use a rounded number for the plugins count #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codewise, this looks fine. 👍 I can't speak to the reason why it's an exact number and whether that was purposeful. @dd32 Any instinct about rounding this number? |
dd32
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See WordPress/wporg-theme-directory#68 (comment). The Theme Directory uses a rounded number ("Over 12,000 free themes to customize your WordPress site"), which is an easier number to read. This PR updates the plugin directory header to round down to the nearest thousand, and adds "over" — which will give us the tagline: