New InputValidator::is_valid_rfc2616_token() method
#849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/inputvalidator-new-valid-token-method
branch
from
dc3619e
to
72841c3
Compare
schlessera
force-pushed
the
feature/inputvalidator-new-valid-token-method
branch
from
701f7a0
to
feb739d
Compare
schlessera
requested changes
Jan 8, 2024
This new method validates that an arbitrary input parameter can be considered valid for use as a "token" as per the RFC 2616 specification. Includes tests. Ref: https://datatracker.ietf.org/doc/html/rfc2616#section-2.2
schlessera
force-pushed
the
feature/inputvalidator-new-valid-token-method
branch
from
fef3fb6
to
80cd9e5
Compare
|
@jrfnl I've made the changes we've discussed in the call. Do you want to take a final look? |
schlessera
approved these changes
Jan 8, 2024
|
@schlessera Thanks for working on this together. all looks good to me. |
|
@schlessera Shall I clean up the branch before merge ? Or will you squash merge ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
This is a:
Context
The new method is intended to be used as a helper to allow for making solving #845 / #847 more straight-forward.
Detailed Description
This new method validates that an arbitrary input parameter can be considered valid for use as a "token" as per the RFC 2616 specification.
Includes tests.
Ref: https://datatracker.ietf.org/doc/html/rfc2616#section-2.2