Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow integers as cookie names #847

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Allow integers as cookie names #847

merged 4 commits into from
Jun 3, 2024

Commits on Jun 3, 2024

  1. Allow integers as cookie names 

    Modify data validation checks, exception messages, and docblocks to allow cookie names to be integers. This affects both the constructor and the parse() method.
Also modified unit tests to allow strings and integers, and to validate the updated exception messages.
    @nosilver4u @jrfnl
    nosilver4u authored and jrfnl committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b2befdb View commit details
    Browse the repository at this point in the history

  2. use RFC 2616 input validator 

    Updated the Cookie token/name validation to use the new InputValidator::is_valid_rfc2616_token() method, updated the exception messages, and modified the test cases to look for the updated exceptions.
    @nosilver4u @jrfnl
    nosilver4u authored and jrfnl committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    7cf47d5 View commit details
    Browse the repository at this point in the history

  3. Allow for empty cookie $name when checking for validity

    @schlessera @jrfnl
    schlessera authored and jrfnl committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    1906cd0 View commit details
    Browse the repository at this point in the history

  4. Cookie: allow for integers - improve tests 

    The tests did now test that anything but integers as well as strings were rejected, but did not test that an input with a valid type, but an invalid value was also rejected.

Fixed now.
    @jrfnl
    jrfnl committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    a83a4da View commit details
    Browse the repository at this point in the history