Docs: full review of Hook documentation #646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by issue #220, I've:
transport.internal....
hooks.Note:
With some of the additional hooks, it wasn't always clear where to place them within this loose order, so suggestions to improve the order are welcome.
Also note that the naming of the
request.progress
hook seems inconsistent. I do understand why the hook usesrequest
instead ofrequests
, but this may be something to revisit at a later point in time.