Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only decompress with proper content-encoding header #438

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

jerrm
Copy link

@jerrm jerrm commented Nov 22, 2020

Closes #437

@codecov-io
Copy link

Codecov Report

Merging #438 (001a345) into master (b304eef) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #438      +/-   ##
============================================
- Coverage     93.12%   93.07%   -0.05%     
- Complexity      763      764       +1     
============================================
  Files            21       21              
  Lines          1788     1790       +2     
============================================
+ Hits           1665     1666       +1     
- Misses          123      124       +1     
Impacted Files Coverage Δ Complexity Δ
library/Requests.php 81.78% <100.00%> (+0.11%) 120.00 <0.00> (+1.00)
library/Requests/Transport/fsockopen.php 94.35% <0.00%> (-0.57%) 69.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b304eef...001a345. Read the comment docs.

@jrfnl jrfnl changed the base branch from stable to develop June 18, 2021 09:57
@jrfnl
Copy link
Member

jrfnl commented Aug 13, 2021

@jerrm Hiya!

We're currently planning two triage sessions for Requests 2.0 and would like to invite you to join us in one or both of these sessions to talk us through the PR and discuss it.

The triage sessions are currently planned for:

  • Friday August 20, 07:00 - 11:00 UTC
  • Friday September 3, 07:00 - 11:00 UTC

Would you be available to join us during those times on one of those days ?

Also: would you be willing and able to add some tests for this change to the PR ?

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes:

  • Needs rebase & conflict solving.
  • The hard-coded array should become a class constant.
  • Check needs to be done whether the array is complete for these purposes.
  • Can this be done without using the performance-poor array_intersect() ?
  • Needs tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

".tgz" files somtimes decompressed in error.
3 participants