Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs: Try to add a single space to avoid screen reader run-on sentences #1641

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

alexstine
Copy link
Contributor

@alexstine alexstine commented Jun 22, 2023

See #1646

Not sure if this will work or not, but worth a try. Might need to use a non-breaking space here.

@alexstine alexstine added [Type] Bug Something isn't working on the Learn website. Accessibility Fix or enhancement related to accessibility. labels Jun 22, 2023
@alexstine alexstine self-assigned this Jun 22, 2023
@adamwoodnz
Copy link
Contributor

Not sure if this will work or not, but worth a try. Might need to use a non-breaking space here.

I think the browser will combine these spaces. Are you not able to test it?

For me Voiceover reads the links separately when I use tab, maybe I'm navigating the content differently?

@alexstine
Copy link
Contributor Author

@adamwoodnz This is a Windows-specific bug, sorry, should have spelled that out. Voiceover and Windows screen readers work differently in the way that Voiceover traverses the content one item at a time where NVDA reads the links like a sentence due to the display: inline; set. I think that is okay for breadcrumbs, but to get the best verbosity results, it needs to be "Link 1, Link2, etc." Breadcrumbs can be tricky... I wonder what would happen if we tried rendering them as display: block;. Then there likely would not be a need for the screen reader text anymore. That's above my styling paygrade though not having vision.

@adamwoodnz
Copy link
Contributor

I wonder what would happen if we tried rendering them as display: block;. Then there likely would not be a need for the screen reader text anymore.

Yeah this might be worth a try. display: block children in a flex row would be visually the same. I've been meaning to get a windows environment set up on my mac so I can test with NVDA.

@adamwoodnz adamwoodnz linked an issue Jun 23, 2023 that may be closed by this pull request
@adamwoodnz adamwoodnz added the [Dev] Needs Testing Website development issues needing testing. label Jun 23, 2023
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires testing on Windows with NVDA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Fix or enhancement related to accessibility. [Dev] Needs Testing Website development issues needing testing. [Type] Bug Something isn't working on the Learn website.
Projects
Status: In Review (PRs only)
Development

Successfully merging this pull request may close these issues.

Breadcrumbs aren't read individually by NVDA
2 participants