Expose buttons as `interactive' commands #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbfalcon
force-pushed
the
feature/button-commands
branch
from
11ae1b6
to
d8a5e98
Compare
I often found it useful to view a symbol in the manual, jump to its source etc., but navigating to the corresponding buttons was cumbersome. As such, expose them as `interactive' commands: `helpful-view-in-manual', .... Refactor the "toggle tracing" code into a separate function, since it used by the toggle trace button and its corresponding `interactive' command.
`nil' is also a symbol.
nbfalcon
force-pushed
the
feature/button-commands
branch
2 times, most recently
from
f32a9d8
to
6a50593
Compare
Store the source sexp in helpful buffers, since it is needed by show-callees. This should now be all buttons.
nbfalcon
force-pushed
the
feature/button-commands
branch
from
6a50593
to
0f20582
Compare
|
This PR should now cover all buttons. There is one question though: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often found it useful to view a symbol in the manual, jump to its source etc.,
but navigating to the corresponding buttons was cumbersome. As such, expose them
as
interactivecommands, with mnemoic keybindings beginning withC-c:helpful-view-in-manual(C-c m)helpful-goto-source(C-c s)helpful-toggle-edebug(C-c e)helpful-toggle-tracing(C-c t)