more precise handling of maps:remove

Summary: More precise handling of `maps:remove(Key, Map)` when `Map` is a shape and `Key` is not an atom literal: it makes all the associations in `Map` optional instead of converting to a dictionary.

Reviewed By: VLanvin

Differential Revision: D57205786

fbshipit-source-id: b775b49ff48fb171b24f9880d2816dc1108f30c9

eqwalizer/src/main/scala/com/whatsapp/eqwalizer/tc/ElabApplyCustom.scala

@@ -411,8 +411,7 @@ class ElabApplyCustom(pipelineContext: PipelineContext) {
  val props = shape.props.filter(_.key != key)
  shape.copy(props = props)
  case _ =>
- val valTy = subtype.join(shape.props.map(_.tp))
- DictMap(AtomType, valTy)
+ ShapeMap(shape.props.map { case ReqProp(k, v) => OptProp(k, v); case prop => prop })
  }
  case UnionType(tys) =>
  subtype.join(tys.map(remove))

eqwalizer/test_projects/check/src/custom.erl.check

@@ -2920,8 +2920,15 @@ maps_remove2(M) -> | OK |
 ) -> #{a := integer()}. | |
 maps_remove3_neg(A, M) -> | ERROR |
  maps:remove(A, M). | | maps:remove(A, M).
- | | Expression has type: dict map #D{atom() => number()}
- | | Context expected type: shape map #S{a := number()}
+ | | Expression has type: #S{a => number()}
+ | | Context expected type: #S{a := number()}
+ | | 
+ | | These associations do not match:
+ | | 
+ | | #S{
+ | | - a := ...
+ | | + a => ...
+ | | }
  | |
 -spec maps_remove4( | |
  #{a := integer(), b := atom()} | | |