Skip to content

Commit

Permalink
Revert IPC protocol merge
Browse files Browse the repository at this point in the history
Summary: Essentially a manual revert of D51524775 and D51584599, since these two diffs may be the cause of errors in CI.

Reviewed By: perehonchuk

Differential Revision: D52372925

fbshipit-source-id: 6530356dcd7de6949eec7dd87364860fa09c2782
  • Loading branch information
VLanvin authored and facebook-github-bot committed Dec 21, 2023
1 parent 090fc58 commit 22c719e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions eqwalizer/src/main/scala/com/whatsapp/eqwalizer/Main.scala
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ object Main {
}
val modules = ipcArgs.tail
val modulesAndStorages = modules.distinct.flatMap(m => DbApi.getAstStorage(m).map(m -> _))
if (config.useElp()) {
ELPDiagnostics.getDiagnosticsIpc(modulesAndStorages)
if (config.mode == Mode.Shell) {
ELPDiagnostics.getDiagnosticsIpcShell(modulesAndStorages)
} else {
ELPDiagnostics.getDiagnosticsIpcMiniElp(modulesAndStorages)
ELPDiagnostics.getDiagnosticsIpc(modulesAndStorages)
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ object ELPDiagnostics {
def getDiagnosticsString(module: String, astStorage: DbApi.AstStorage, options: Options = noOptions): String =
toJsonObj(Map(module -> getDiagnostics(module, astStorage, options))).render(indent = 2)

def getDiagnosticsIpcMiniElp(modulesAndStorages: Iterable[(String, DbApi.AstStorage)]): Unit =
def getDiagnosticsIpc(modulesAndStorages: Iterable[(String, DbApi.AstStorage)]): Unit =
try {
val diagnosticsByModule = mutable.Map.empty[String, List[Error]]
for { (module, astStorage) <- modulesAndStorages } {
Expand All @@ -44,7 +44,7 @@ object ELPDiagnostics {
case Ipc.Terminated => ()
}

def getDiagnosticsIpc(modulesAndStorages: Iterable[(String, DbApi.AstStorage)]): Unit =
def getDiagnosticsIpcShell(modulesAndStorages: Iterable[(String, DbApi.AstStorage)]): Unit =
try {
for { (module, astStorage) <- modulesAndStorages } {
if (Ipc.shouldEqwalize(module)) {
Expand Down

0 comments on commit 22c719e

Please sign in to comment.