Pattern language changes for syntax highlight code thatwill be pr'd to Imhex's repo later today. #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paxcut
commented
May 22, 2024
paxcut
commented
- Better parser support for identifier types of variable definitions only.
- Fixed typo in parser_manager.cpp.
- Parser errors were overwriting preprocessor/lexer errors. Make sure they are all added.
- If ast fails to be created make sure that the parsed tokens are saved before returning.
- Change a variable to a more appropriate name in preprocessor and remove excluded location validation.
- Rearrange identifier type enumeration values to support value ordering of importance (bigger are more important types and preferred if choice can be made). Also removed types that were not identifiers.
… identifier types of variable definitions only. Fixed typo in parser_manager.cpp. Parser errors were overwriting preprocessor/lexer errors. Make sure they are all added. If ast fails to be created make sure that the parsed tokens are saved before returning. Change to a more appropriate name in preprocessor and remove excluded location validation. Rearrange identifier type enumeration values to support value ordering of importance (bigger are more important types and preferred if choice can be made). Also removed types that were not identifiers.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
=======================================
Coverage 25.04% 25.04%
=======================================
Files 137 137
Lines 9940 9936 -4
Branches 5506 5500 -6
=======================================
- Hits 2489 2488 -1
+ Misses 4850 4849 -1
+ Partials 2601 2599 -2 ☔ View full report in Codecov by Sentry. |
…here the next break will occur. The value returned by getPauseLine() is the number of the line above the one it wants, but the values it may return range from zero to lines-1. When the code that's being executed cannot be seen because it is in another file, the debugger sets the line to zero which in turn is adjusted to line number by subtracting one. As negative line number locations are asserted against getPauseLine() now makes sure that the smallest number it can return is one. fix: found a bug where multi variable definitions were being label incorrectly by the parser which caused the highlighter to ignore all instances of the variables. Due to the name of the function involved it appeared that only custom type member definitions were being processed, but it appears the function variable definitions were processed by the code. In order to tell one set of variables from the other an specific node variable that only exists in one of the two provides the litmus test.
…preprocessor_improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.