Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add announcement for category page #11644

Merged
merged 10 commits into from
May 29, 2024

Conversation

harriebird
Copy link
Collaborator

Proposed changes

Add announcement form on category page.
To achieve this, changes are made to the models Change and Announcement.
This solves issue #11106.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@harriebird harriebird force-pushed the feature/add-announcement-to-category branch from 0b80838 to 9bdbc63 Compare May 17, 2024 04:39
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.57%. Comparing base (6aee586) to head (33cf2f7).
Report is 1850 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11644      +/-   ##
==========================================
- Coverage   90.82%   90.57%   -0.26%     
==========================================
  Files         554      573      +19     
  Lines       57306    58680    +1374     
  Branches     9122     9373     +251     
==========================================
+ Hits        52046    53147    +1101     
- Misses       3640     3843     +203     
- Partials     1620     1690      +70     
Files Coverage Δ
weblate/trans/forms.py 87.76% <100.00%> (-0.10%) ⬇️
..._announcement_severity_change_category_and_more.py 100.00% <100.00%> (ø)
weblate/trans/models/announcement.py 89.58% <100.00%> (+0.22%) ⬆️
weblate/trans/templatetags/translations.py 89.51% <ø> (+0.30%) ⬆️
weblate/trans/tests/test_manage.py 98.67% <100.00%> (+0.09%) ⬆️
weblate/trans/views/basic.py 82.73% <ø> (-0.20%) ⬇️
weblate/wladmin/tests.py 100.00% <100.00%> (ø)
weblate/trans/models/change.py 81.66% <33.33%> (+2.65%) ⬆️

... and 248 files with indirect coverage changes

@harriebird harriebird force-pushed the feature/add-announcement-to-category branch 4 times, most recently from 13cdb3b to c1d6509 Compare May 21, 2024 09:01
@nijel nijel added this to the 5.6 milestone May 21, 2024
weblate/trans/views/basic.py Outdated Show resolved Hide resolved
@harriebird harriebird force-pushed the feature/add-announcement-to-category branch from 8087ffe to dfc0391 Compare May 22, 2024 11:16
@harriebird harriebird force-pushed the feature/add-announcement-to-category branch from 7a2313a to 840813d Compare May 29, 2024 06:56
@nijel nijel linked an issue May 29, 2024 that may be closed by this pull request
@nijel nijel self-assigned this May 29, 2024
@nijel nijel enabled auto-merge (squash) May 29, 2024 09:07
@nijel
Copy link
Member

nijel commented May 29, 2024

Scheduled for merge, thanks for your contribution!

@nijel nijel merged commit 794c600 into WeblateOrg:main May 29, 2024
27 of 29 checks passed
@emmapeel2
Copy link
Contributor

I have tried this new feature, but when I post an announcement to the Tor Browser category at https://hosted.weblate.org/projects/tor/tor-browser/ , the announcement is displayed in the whole project, not only on the category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add announcements to Categories
3 participants