Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): turn on digest notification on new strings by default #11641

Merged
merged 1 commit into from
May 17, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented May 15, 2024

Proposed changes

This should encourage users to complete the translation they contributed to.

It applies to new users only.

Fixes #10533

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel added this to the 5.6 milestone May 15, 2024
@nijel nijel self-assigned this May 15, 2024
@nijel nijel force-pushed the notifiy-new-string-default branch 2 times, most recently from f539876 to afec07f Compare May 16, 2024 06:18
…ault

This should encourage users to complete the translation they contributed to.

It applies to new users only.

Fixes WeblateOrg#10533
@nijel nijel force-pushed the notifiy-new-string-default branch from afec07f to 66b37a3 Compare May 17, 2024 06:38
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.61%. Comparing base (6aee586) to head (66b37a3).
Report is 1806 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11641      +/-   ##
==========================================
- Coverage   90.82%   90.61%   -0.21%     
==========================================
  Files         554      571      +17     
  Lines       57306    58650    +1344     
  Branches     9122     9372     +250     
==========================================
+ Hits        52046    53148    +1102     
- Misses       3640     3815     +175     
- Partials     1620     1687      +67     
Files Coverage Δ
weblate/accounts/data.py 100.00% <ø> (ø)
weblate/accounts/tests/test_notifications.py 100.00% <100.00%> (ø)
weblate/accounts/tests/test_views.py 100.00% <100.00%> (ø)
weblate/api/tests.py 100.00% <100.00%> (ø)

... and 247 files with indirect coverage changes

@nijel nijel merged commit ae2d130 into WeblateOrg:main May 17, 2024
30 of 31 checks passed
@nijel nijel deleted the notifiy-new-string-default branch May 17, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to set default notification setting for watched projects
1 participant