Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to set default notification setting for watched projects #10533

Closed
2 tasks done
laoneo opened this issue Dec 2, 2023 · 8 comments · Fixed by #11641
Closed
2 tasks done

No way to set default notification setting for watched projects #10533

laoneo opened this issue Dec 2, 2023 · 8 comments · Fixed by #11641
Assignees
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship.
Milestone

Comments

@laoneo
Copy link

laoneo commented Dec 2, 2023

Describe the issue

Thanks for this great project. On the notifications part there is some room for improvements as when you come from transifex, you get a lot of useful notifications which encourage user to finish the translation of a language when stuff changes. Would it be possible to set some defaults for the "New translation component was created" and "New string is available for translation" settings. As IMO for these settings an instant notification should be sent out. Probably some more would be nice too.

I already tried

  • I've read and searched the documentation.
  • I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Got to /accounts/profile/#notifications__1
  2. Check the component and translation notifications

Expected behavior

Some default settings to adjust, either in the GUI or by configuration variable.

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

No response

Weblate deploy checks

No response

Additional context

Kind of related to #5155.

@nijel nijel added enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship. labels Dec 8, 2023
Copy link

github-actions bot commented Dec 8, 2023

This issue has been put aside. It is currently unclear if it will ever be implemented as it seems to cover too narrow of a use case or doesn't seem to fit into Weblate.

Please try to clarify the use case or consider proposing something more generic to make it useful to more users.

@nijel
Copy link
Member

nijel commented Dec 8, 2023

"New string is available for translation" can be pretty noisy when triggered for each string, so you want that one to be digest.

Anyway: Where these additional defaults should be set and by who?

Weblate already has built-in defaults:

DEFAULT_NOTIFICATIONS = [
(SCOPE_ALL, FREQ_INSTANT, "MentionCommentNotificaton"),
(SCOPE_WATCHED, FREQ_INSTANT, "LastAuthorCommentNotificaton"),
(SCOPE_WATCHED, FREQ_INSTANT, "MentionCommentNotificaton"),
(SCOPE_WATCHED, FREQ_INSTANT, "NewAnnouncementNotificaton"),
(SCOPE_ADMIN, FREQ_INSTANT, "MergeFailureNotification"),
(SCOPE_ADMIN, FREQ_INSTANT, "ParseErrorNotification"),
(SCOPE_ADMIN, FREQ_INSTANT, "NewTranslationNotificaton"),
(SCOPE_ADMIN, FREQ_INSTANT, "NewAlertNotificaton"),
(SCOPE_ADMIN, FREQ_INSTANT, "NewAnnouncementNotificaton"),
]

Admin presets are covered by #5155

@laoneo
Copy link
Author

laoneo commented Dec 15, 2023

Thanks for the answer, as I'm using docker, it is probaly not really possible to set these defaults.

I was playing around a bit more with weblate and when I commit new strings or updated strings, weblate receives them correctly from the Github webhook. But no notifications are going out, should I open a new ticket for that?

@nijel
Copy link
Member

nijel commented Dec 22, 2023

#10659 should address notifications for new strings.

@laoneo
Copy link
Author

laoneo commented Dec 22, 2023

Thanks, and what about updated strings? Is this something you want to address too?

@nijel
Copy link
Member

nijel commented Dec 24, 2023

Yes, we should cover that as well.

@nijel nijel added this to the 5.4 milestone Dec 24, 2023
@laoneo
Copy link
Author

laoneo commented Dec 29, 2023

Do you not want to add #10651 to the 5.4 milestone instead of this one? As per your comment this is already possible, just didn't figure out how in docker.

@nijel
Copy link
Member

nijel commented Jan 31, 2024

#10651 is already added to that milestone. I'd like to change the defaults in this issue to give users more notifications. I am not sure if we want to make this admin configurable, though.

@nijel nijel modified the milestones: 5.4, 5.5 Feb 13, 2024
@nijel nijel modified the milestones: 5.5, 5.6 Apr 17, 2024
@nijel nijel self-assigned this May 15, 2024
nijel added a commit to nijel/weblate that referenced this issue May 15, 2024
…ault

This should encourage users to complete the translation they contributed to.

It applies to new users only.

Fixes WeblateOrg#10533
nijel added a commit to nijel/weblate that referenced this issue May 15, 2024
…ault

This should encourage users to complete the translation they contributed to.

It applies to new users only.

Fixes WeblateOrg#10533
nijel added a commit to nijel/weblate that referenced this issue May 16, 2024
…ault

This should encourage users to complete the translation they contributed to.

It applies to new users only.

Fixes WeblateOrg#10533
nijel added a commit to nijel/weblate that referenced this issue May 17, 2024
…ault

This should encourage users to complete the translation they contributed to.

It applies to new users only.

Fixes WeblateOrg#10533
nijel added a commit that referenced this issue May 17, 2024
…ault

This should encourage users to complete the translation they contributed to.

It applies to new users only.

Fixes #10533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. undecided These features might not be implemented. Can be prioritized by sponsorship.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants