Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup various "nil vs empty" confusions in serializaiton of some ObjC types #28747

Conversation

beidson
Copy link
Contributor

@beidson beidson commented May 18, 2024

26b41e6

Cleanup various "nil vs empty" confusions in serializaiton of some ObjC types
rdar://128027011
https://bugs.webkit.org/show_bug.cgi?id=274342

Reviewed by Alex Christensen.

Similar to what I fixed over in https://commits.webkit.org/277627@main, various other ObjC serializers
have some "nil vs empty" confusion that can lead to various wonky side effects.

Let's support the different between nil and empty wherever we can spot it.

* Source/WebKit/Shared/Cocoa/CoreIPCPassKit.h:
(WebKit::CoreIPCPKContact::CoreIPCPKContact):
* Source/WebKit/Shared/Cocoa/CoreIPCPassKit.mm:
(WebKit::CoreIPCPKContact::CoreIPCPKContact):
(WebKit::CoreIPCPKContact::toID const):
* Source/WebKit/Shared/Cocoa/CoreIPCPassKit.serialization.in:

* Source/WebKit/Shared/Cocoa/CoreIPCPersonNameComponents.mm:
(WebKit::CoreIPCPersonNameComponents::toID const):

* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(TEST(IPCSerialization, Basic)):

Canonical link: https://commits.webkit.org/278966@main

6f04da3

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2 βœ… πŸ§ͺ wincairo-tests
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ api-wpe
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ›  wpe-cairo
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress ❌ πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@beidson beidson self-assigned this May 18, 2024
@beidson beidson added the merge-queue Applied to send a pull request to merge-queue label May 19, 2024
…jC types

rdar://128027011
https://bugs.webkit.org/show_bug.cgi?id=274342

Reviewed by Alex Christensen.

Similar to what I fixed over in https://commits.webkit.org/277627@main, various other ObjC serializers
have some "nil vs empty" confusion that can lead to various wonky side effects.

Let's support the different between nil and empty wherever we can spot it.

* Source/WebKit/Shared/Cocoa/CoreIPCPassKit.h:
(WebKit::CoreIPCPKContact::CoreIPCPKContact):
* Source/WebKit/Shared/Cocoa/CoreIPCPassKit.mm:
(WebKit::CoreIPCPKContact::CoreIPCPKContact):
(WebKit::CoreIPCPKContact::toID const):
* Source/WebKit/Shared/Cocoa/CoreIPCPassKit.serialization.in:

* Source/WebKit/Shared/Cocoa/CoreIPCPersonNameComponents.mm:
(WebKit::CoreIPCPersonNameComponents::toID const):

* Tools/TestWebKitAPI/Tests/IPC/IPCSerialization.mm:
(TEST(IPCSerialization, Basic)):

Canonical link: https://commits.webkit.org/278966@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Cleanup-various-nil-vs-empty-confusions-in-serializaiton-of-some-ObjC-types branch from 6f04da3 to 26b41e6 Compare May 19, 2024 01:24
@webkit-commit-queue
Copy link
Collaborator

Committed 278966@main (26b41e6): https://commits.webkit.org/278966@main

Reviewed commits have been landed. Closing PR #28747 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 26b41e6 into WebKit:main May 19, 2024
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants