Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GlyphPage::fill() should take in a std::span #28743

Merged
merged 1 commit into from
May 18, 2024
Merged

GlyphPage::fill() should take in a std::span #28743

merged 1 commit into from
May 18, 2024

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented May 17, 2024 •
edited by webkit-early-warning-system

521e9dc

GlyphPage::fill() should take in a std::span
https://bugs.webkit.org/show_bug.cgi?id=274341

Reviewed by Darin Adler.

* Source/WebCore/platform/graphics/Font.cpp:
(WebCore::fillGlyphPage):
(WebCore::createAndFillGlyphPage):
* Source/WebCore/platform/graphics/GlyphPage.h:
* Source/WebCore/platform/graphics/coretext/GlyphPageCoreText.cpp:
(WebCore::shouldFillWithVerticalGlyphs):
(WebCore::GlyphPage::fill):
* Source/WebCore/platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
(WebCore::GlyphPage::fill):
* Source/WebCore/platform/graphics/skia/GlyphPageSkia.cpp:
(WebCore::GlyphPage::fill):
* Source/WebCore/platform/graphics/win/GlyphPageTreeNodeWin.cpp:
(WebCore::GlyphPage::fill):

Canonical link: https://commits.webkit.org/278959@main

8052680

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@cdumez cdumez self-assigned this May 17, 2024
@cdumez cdumez added the Text For bugs in text layout and rendering, including international text support. label May 17, 2024
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 3832089)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ❌ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2   🧪 wincairo-tests
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac ❌ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ✅ 🛠 wpe-cairo
⏳ 🧪 api-ios   🧪 mac-wk2   🛠 gtk
  🛠 tv ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
  🛠 watch
  🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 17, 2024
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label May 17, 2024
@cdumez cdumez force-pushed the 274341_GlyphPage_fill_span branch from 3832089 to ffb3cbb Compare May 17, 2024 23:47
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash ffb3cbb)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ❌ 🧪 wincairo-tests
✅ 🧪 webkitperl ❌ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
  🧪 api-ios ❌ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🧪 gtk-wk2
  🛠 tv-sim ✅ 🧪 mac-wk2-stress   🧪 api-gtk
  🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 18, 2024
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label May 18, 2024
@cdumez cdumez force-pushed the 274341_GlyphPage_fill_span branch from ffb3cbb to 5a8321a Compare May 18, 2024 01:41
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 5a8321a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2 ❌ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
⏳ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2   🧪 gtk-wk2
  🛠 tv-sim ✅ 🧪 mac-wk2-stress ✅ 🧪 api-gtk
  🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez marked this pull request as ready for review May 18, 2024 02:52
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 18, 2024
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label May 18, 2024
@cdumez cdumez force-pushed the 274341_GlyphPage_fill_span branch from 5a8321a to 8052680 Compare May 18, 2024 03:37
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 8052680)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ❌ 🧪 wpe-wk2 ✅ 🧪 wincairo-tests
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 wpe-cairo
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ❌ 🧪 api-gtk
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label May 18, 2024
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label May 18, 2024
@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 18, 2024
@cdumez
GlyphPage::fill() should take in a std::span
521e9dc 
https://bugs.webkit.org/show_bug.cgi?id=274341

Reviewed by Darin Adler.

* Source/WebCore/platform/graphics/Font.cpp:
(WebCore::fillGlyphPage):
(WebCore::createAndFillGlyphPage):
* Source/WebCore/platform/graphics/GlyphPage.h:
* Source/WebCore/platform/graphics/coretext/GlyphPageCoreText.cpp:
(WebCore::shouldFillWithVerticalGlyphs):
(WebCore::GlyphPage::fill):
* Source/WebCore/platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
(WebCore::GlyphPage::fill):
* Source/WebCore/platform/graphics/skia/GlyphPageSkia.cpp:
(WebCore::GlyphPage::fill):
* Source/WebCore/platform/graphics/win/GlyphPageTreeNodeWin.cpp:
(WebCore::GlyphPage::fill):

Canonical link: https://commits.webkit.org/278959@main
@webkit-commit-queue
Copy link
Collaborator

Committed 278959@main (521e9dc): https://commits.webkit.org/278959@main

Reviewed commits have been landed. Closing PR #28743 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 521e9dc into WebKit:main May 18, 2024
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

@vitorroriz vitorroriz Awaiting requested review from vitorroriz

@brentfulgham brentfulgham Awaiting requested review from brentfulgham

Assignees

@cdumez cdumez

Labels
Text For bugs in text layout and rendering, including international text support.
Projects
None yet
Milestone
No milestone
5 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler @webkit-ews-buildbot