[WebGPU] Release assert trigged in PipelineLayout::offsetVectorForBindGroup #28716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash b1c84de) |
🛠 mac
🧪 api-wpe
mwyrzykowski
force-pushed
the
eng/WebGPU-Release-assert-trigged-in-PipelineLayoutoffsetVectorForBindGroup
branch
from
b1c84de
to
852547e
Compare
|
EWS run on current version of this PR (hash 852547e) |
mwyrzykowski
added
the
unsafe-merge-queue
…dGroup https://bugs.webkit.org/show_bug.cgi?id=274317 <radar://128065029> Reviewed by Dan Glastonbury. Invalid bind group should return nullptr as it already does in other places in this member function instead of crashing the GPU process. * LayoutTests/TestExpectations: * LayoutTests/fast/webgpu/fuzz-274317-expected.txt: Added. * LayoutTests/fast/webgpu/fuzz-274317.html: Added. Add regression test. * Source/WebGPU/WebGPU/PipelineLayout.mm: (WebGPU::PipelineLayout::offsetVectorForBindGroup): Canonical link: https://commits.webkit.org/279013@main
webkit-commit-queue
force-pushed
the
eng/WebGPU-Release-assert-trigged-in-PipelineLayoutoffsetVectorForBindGroup
branch
from
852547e
to
cd8059f
Compare
|
Committed 279013@main (cd8059f): https://commits.webkit.org/279013@main Reviewed commits have been landed. Closing PR #28716 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cd8059f
852547e
🛠 wincairo🛠 ios-sim🧪 wpe-wk2🧪 wincairo-tests🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 ios-wk2-wpt🧪 mac-wk1🧪 api-ios🧪 mac-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 gtk-wk2🛠 tv-sim🧪 mac-wk2-stress🧪 api-gtk🛠 watch🛠 watch-sim