Adhere to POSIX for fd_pwrite w/ append flag #3390
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. |
yagehu
force-pushed
the
yagehu/pwrite-append
branch
2 times, most recently
from
bb6b85b
to
b92c918
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3390 +/- ##
==========================================
- Coverage 80.85% 79.84% -1.02%
==========================================
Files 159 253 +94
Lines 23035 34945 +11910
Branches 4734 6135 +1401
==========================================
+ Hits 18626 27902 +9276
- Misses 3129 5613 +2484
- Partials 1280 1430 +150 ☔ View full report in Codecov by Sentry. |
This commit makes the `fd_pwrite` behave as specified by POSIX when the fd was opened with the `append` flag. Specifically, [POSIX][1] says that `pwrite` should write to the specified offset "regardless of whether O_APPEND is set". fixes WasmEdge#3389 [1]: https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/ Signed-off-by: Yage Hu <[email protected]>
yagehu
force-pushed
the
yagehu/pwrite-append
branch
from
b92c918
to
1b84b54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the
fd_pwritebehave as specified by POSIX when the fd was opened with theappendflag. Specifically, POSIX says thatpwriteshould write to the specified offset "regardless of whether O_APPEND is set".fixes #3389