Supported WASI-NN streaming extension for NNRPC. #3386
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvind Ganesh <[email protected]>
|
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. |
github-actions
bot
added
c-CLI
Signed-off-by: Arvind Ganesh <[email protected]>
arvganesh
force-pushed
the
streaming
branch
2 times, most recently
from
fa3a2b6
to
b792f9a
Compare
Signed-off-by: Arvind Ganesh <[email protected]>
Signed-off-by: Arvind Ganesh <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3386 +/- ##
==========================================
- Coverage 79.93% 79.84% -0.09%
==========================================
Files 251 253 +2
Lines 34368 34937 +569
Branches 5966 6148 +182
==========================================
+ Hits 27471 27897 +426
- Misses 5507 5621 +114
- Partials 1390 1419 +29 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Arvind Ganesh <[email protected]>
hydai
requested changes
May 20, 2024
| @@ -155,12 +155,30 @@ TEST(WasiNNTest, OpenVINOBackend) { | |||
| EXPECT_TRUE(FuncInst->isHostFunction()); | |||
| auto &HostFuncGetOutput = | |||
| dynamic_cast<WasmEdge::Host::WasiNNGetOutput &>(FuncInst->getHostFunc()); | |||
| // Get the function "get_output_single". | |||
There was a problem hiding this comment.
I got confused. Why do you add these tests to the OpenVINO backend? The OpenVINO backend does not implement these LLM-related extension functions. That's why the unit tests will fail when trying to get the non-existing functions.
AkihiroSuda
reviewed
May 24, 2024
| Req.set_resource_handle(Context); | ||
| Req.set_index(Index); | ||
| wasi_ephemeral_nn::GetOutputResult Res; | ||
| auto Status = Stub->GetOutput(&ClientContext, Req, &Res); |
There was a problem hiding this comment.
Suggested change
| auto Status = Stub->GetOutput(&ClientContext, Req, &Res); | |
| auto Status = Stub->GetOutputSingle(&ClientContext, Req, &Res); |
|
Hi @arvganesh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3319. This PR did the following for the following functions:
ComputeSingle,GetOutputSingle, andFiniSingle.ComputeSingle,GetOutputSingle,FiniSingle