Interface types #3380
Draft
Interface types #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. |
github-actions
bot
added
c-CLI
dannypsnl
force-pushed
the
component-model/instantiate
branch
3 times, most recently
from
4d01a28
to
3436114
Compare
dannypsnl
force-pushed
the
component-model/instantiate
branch
2 times, most recently
from
d61259d
to
fdb35e5
Compare
dannypsnl
force-pushed
the
interface-types
branch
from
90fdb13
to
03cf052
Compare
github-actions
bot
removed
c-Test
dannypsnl
force-pushed
the
component-model/instantiate
branch
from
1a908d8
to
f25bc16
Compare
dannypsnl
force-pushed
the
interface-types
branch
from
fb84d26
to
ed0b064
Compare
dannypsnl
force-pushed
the
component-model/instantiate
branch
2 times, most recently
from
edf18b4
to
fa0f78c
Compare
This was referenced May 30, 2024
* section order will affect index space * skip validation process for now * nested core module instantiation * record all environments had been used * add type and core:type into index space (in component instance) * (FIXME) import section: the current implementation will treat a plugin as module instance instead a component instance, in the end we should have both * instantiate component sort part * export function instance out, so we can run it from CLI * canoncial lift without options * canoncial lower without options * unify component and module instance in VM * drafting inline exports concept Signed-off-by: Lîm Tsú-thuàn <[email protected]>
* wasi-http implementation * drafting example for test * fix a bug in store manager, soft modules do it wrong * fix instance problem misc * update to follow review feedback * mark TODO * add prefix * reinterpret_cast * format stuff Signed-off-by: Lîm Tsú-thuàn <[email protected]>
- canonical changes - extracting out the instantiate of each section to its own file - `alias` is correct, the bug is coming from the demo code Signed-off-by: Lîm Tsú-thuàn <[email protected]>
1. [component] create `Executor::lowering` function that gets a higher function instance, returns a lower function instance 2. add enum `TypeCode::String` 3. add `StrVariant` so host function can operate string 4. [plugin] update wasi-http implementation to use new stuffs Signed-off-by: Lîm Tsú-thuàn <[email protected]>
* pushing canonical lifting a bit, now call flow has no error came out * add header * cannot allocate ValVariant * `vector` of component instance use push_back * fix test build * remove const descriptor * avoid occurs casting which will fail on some platforms * remove `const` * proper initialize * anonymous namespace * lift lower function that occurs string correctly misc * mark TODO * use hard code version to allocate string in memory * abort execution if run into unimplemented option * add formatter for AST type * use formatter Signed-off-by: Lîm Tsú-thuàn <[email protected]>
misc * complete defined value type formatter * format the Component function type Signed-off-by: Lîm Tsú-thuàn <[email protected]>
NOTE: some internal bugs still there, so the demo haven't fully work yet. Signed-off-by: Lîm Tsú-thuàn <[email protected]>
misc: remove unused code Signed-off-by: Lîm Tsú-thuàn <[email protected]>
misc * missing `break` in cases * adjustment Signed-off-by: Lîm Tsú-thuàn <[email protected]>
Signed-off-by: Lîm Tsú-thuàn <[email protected]>
…ng content misc * missing `break` * reduce interface of `StrVariant` Signed-off-by: Lîm Tsú-thuàn <[email protected]>
misc: format Signed-off-by: Lîm Tsú-thuàn <[email protected]>
Signed-off-by: Lîm Tsú-thuàn <[email protected]>
Signed-off-by: Lîm Tsú-thuàn <[email protected]>
Signed-off-by: Lîm Tsú-thuàn <[email protected]>
Signed-off-by: Lîm Tsú-thuàn <[email protected]>
Signed-off-by: Lîm Tsú-thuàn <[email protected]>
dannypsnl
force-pushed
the
component-model/instantiate
branch
from
fa0f78c
to
26b64b1
Compare
Signed-off-by: Lîm Tsú-thuàn <[email protected]>
Signed-off-by: Lîm Tsú-thuàn <[email protected]>
Signed-off-by: Lîm Tsú-thuàn <[email protected]>
Signed-off-by: Lîm Tsú-thuàn <[email protected]>
dannypsnl
force-pushed
the
interface-types
branch
from
ed0b064
to
c9041b9
Compare
Signed-off-by: Lîm Tsú-thuàn <[email protected]>
dannypsnl
force-pushed
the
component-model/instantiate
branch
from
005c8f2
to
cb85c09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: since we are going to merge #3218, once it merged we cherry-pick 90fdb13.