-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][Wasi] add Wasi-Socket #3147
base: master
Are you sure you want to change the base?
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Commit acc7e23a2b1b8152ee7433f773790fd825d8c07aThe pull request "[WIP][Wasi] add Wasi-Socket" adds socket support to the Wasi (WebAssembly System Interface) in the WasmEdge project. The following are the major changes: New headers files were added under the New classes are implemented in 5 new source files under There's an addition to the CMakeLists.txt file to handle the build configuration for the new code. The critical file The The terms TCP, UDP, and IPNameLookup imply there is support for both UDP and TCP type sockets, and potential DNS resolution functionality. Potential Issues:
|
fb72ae7
to
2cce340
Compare
e21da8b
to
fa8919f
Compare
cea1632
to
ef09b1e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3147 +/- ##
==========================================
- Coverage 77.31% 73.21% -4.11%
==========================================
Files 185 192 +7
Lines 25599 27018 +1419
Branches 5639 5999 +360
==========================================
- Hits 19791 19780 -11
- Misses 4382 5803 +1421
- Partials 1426 1435 +9 ☔ View full report in Codecov by Sentry. |
fdcac75
to
0f5cb87
Compare
Signed-off-by: Sylveon <[email protected]>
Wasi threads
framework
network
instance
drop
udp-create-socket
create_udp_socket(address-family)
udp
udpsocket (resource)
instance
drop
subscribe
(poll function, will remove in preview 3)start_bind(address, address-family)
check ip is allowed
finish_bind(handle)
stream(remote-address)
check child stream (resource)
check remote address allowed
local_address()
remote_address()
AddressFamily()
UnicastHopLimit()
SetUnicastHopLimit()
GetReceiveBufferSize()
SetReceiveBufferSize
()GetSendBufferSize()
SetSendBufferSize()
incoming-datagram-stream
instance (user can not use this)
drop
subscribe
(poll function, will remove in preview 3)receive(max-results)
outgoing-datagram-stream
instance (user can not use this)
drop
subscribe
(poll function, will remove in preview 3)check-send()
send(list)
tcp-create-socket
create_tcp_socket(address-family)
tcp
tcp-socket
instance
drop
subscribe
(poll function, will remove in preview 3)start-bind
finish-bind
start-connect
finish-connect
start-listen
finish-listen
accept
local-address
remote-address
is_listening
address_family
set_listen_backlog_size
keep-alive-enabled
set-keep-alive-enabled
keep-alive-idle-time
setkeep-alive-idle-time
keep-alive-interval
set-keep-alive-interval
keep-alive-count
set-keep-alive-count
hop-limit
set-hop-limit
receive-buffer-size
set-receive-buffer-size
send-buffer-size
set-send-buffer-size
shutdown
IpNameLookup
resolve-addresses
resolve-address-stream
instance
drop
subscribe
(poll function, will remove in preview 3)resolve-next-address