-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump actions/upload-artifact from 3 to 4 #3099
base: master
Are you sure you want to change the base?
Bump actions/upload-artifact from 3 to 4 #3099
Conversation
Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR. Commit f3dba433b2f28cd237b09c03df71367579eb5e23The GitHub Pull Request titled "Bump actions/upload-artifact from 3 to 4" primarily focuses on updating the version of the actions/upload-artifact action used in the project's GitHub workflows. The dependency (actions/upload-artifact) version has been updated from version 3 to version 4 across different workflow files. A total of 16 files have been changed with 50 additions and 50 deletions related to this version bump. However, potential problems are hard to identify without knowing the context, given the changes only reflect a version change in a GitHub Actions Utility. The developer should ensure that the features and capabilities provided by version 4 are compatible with the project requirements. Also, it's recommended to check the release notes and Commits between version 3 and version 4 to identify any disruptive changes. When updating action versions or other dependencies, it's also essential to consider other potential side effects. For example, other dependencies might not be compatible with the new version, or the new version might introduce updated behaviors or breaking changes. In this case, there should be no breaking changes according to the semver versioning convention, but it's always a good idea to review the change log and test these changes thoroughly to avoid deployment issues. Finally, the Pull Request does not appear to include any addition of unit tests or changes to existing tests to verify the functionality with the updated dependency. Especially with a significant version change like this, it's crucial to update tests in parallel to ensure that existing functionality isn't breaking due to the update. The reviewer should request thorough testing before considering merging the Pull Request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3099 +/- ##
=======================================
Coverage 76.89% 76.89%
=======================================
Files 176 176
Lines 24232 24232
Branches 5139 5139
=======================================
Hits 18632 18632
Misses 4314 4314
Partials 1286 1286 ☔ View full report in Codecov by Sentry. |
5273bbd
to
c567fba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the manylinux2014 doesn't fit the minimum requirement of this action, we will pause to merge this one unless we drop the manylinux2014 support.
cdb02d7
to
ccddf28
Compare
af4e4fb
to
0fad008
Compare
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
0fad008
to
f3dba43
Compare
Bumps actions/upload-artifact from 3 to 4.
Release notes
Sourced from actions/upload-artifact's releases.
Commits
c7d193f
Merge pull request #466 from actions/v4-beta13131bb
licensed cache4a6c273
Merge branch 'main' into v4-betaf391bb9
Merge pull request #465 from actions/robherley/v4-documentation9653d03
Apply suggestions from code review875b630
add limitations sectionecb2146
add compression example5e7604f
trim some repeated infod6437d0
naming1b56155
s/v4-beta/v4/gYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)