Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/upload-artifact from 3 to 4 #3099

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2023

Bumps actions/upload-artifact from 3 to 4.

Release notes

Sourced from actions/upload-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

For more information, see the @​actions/artifact documentation.

New Contributors

Full Changelog: actions/upload-artifact@v3...v4.0.0

v3.1.3

What's Changed

Full Changelog: actions/upload-artifact@v3...v3.1.3

v3.1.2

  • Update all @actions/* NPM packages to their latest versions- #374
  • Update all dev dependencies to their most recent versions - #375

v3.1.1

  • Update actions/core package to latest version to remove set-output deprecation warning #351

v3.1.0

What's Changed

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from hydai as a code owner December 18, 2023 13:57
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Dec 18, 2023
Copy link
Member

juntao commented Dec 18, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit f3dba433b2f28cd237b09c03df71367579eb5e23

The GitHub Pull Request titled "Bump actions/upload-artifact from 3 to 4" primarily focuses on updating the version of the actions/upload-artifact action used in the project's GitHub workflows. The dependency (actions/upload-artifact) version has been updated from version 3 to version 4 across different workflow files. A total of 16 files have been changed with 50 additions and 50 deletions related to this version bump.

However, potential problems are hard to identify without knowing the context, given the changes only reflect a version change in a GitHub Actions Utility. The developer should ensure that the features and capabilities provided by version 4 are compatible with the project requirements. Also, it's recommended to check the release notes and Commits between version 3 and version 4 to identify any disruptive changes.

When updating action versions or other dependencies, it's also essential to consider other potential side effects. For example, other dependencies might not be compatible with the new version, or the new version might introduce updated behaviors or breaking changes. In this case, there should be no breaking changes according to the semver versioning convention, but it's always a good idea to review the change log and test these changes thoroughly to avoid deployment issues.

Finally, the Pull Request does not appear to include any addition of unit tests or changes to existing tests to verify the functionality with the updated dependency. Especially with a significant version change like this, it's crucial to update tests in parallel to ensure that existing functionality isn't breaking due to the update. The reviewer should request thorough testing before considering merging the Pull Request.

@github-actions github-actions bot added the c-CI label Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e78fedf) 76.89% compared to head (f3dba43) 76.89%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3099   +/-   ##
=======================================
  Coverage   76.89%   76.89%           
=======================================
  Files         176      176           
  Lines       24232    24232           
  Branches     5139     5139           
=======================================
  Hits        18632    18632           
  Misses       4314     4314           
  Partials     1286     1286           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from 5273bbd to c567fba Compare December 20, 2023 17:06
Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the manylinux2014 doesn't fit the minimum requirement of this action, we will pause to merge this one unless we drop the manylinux2014 support.

@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch 2 times, most recently from cdb02d7 to ccddf28 Compare January 3, 2024 02:43
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch 3 times, most recently from af4e4fb to 0fad008 Compare January 5, 2024 11:31
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from 0fad008 to f3dba43 Compare January 9, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-CI dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants