Make analogy work through upgrades #1177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analogy now works through most one-to-one upgrades * Analogy is now performed on upgraded versions * The original analogy action chain is modified to work on an upgraded workflow. * Fixes connection port name upgrades * Will not fix function upgrades on existing modules * uses module location to find upgrade map * We may want to find a more robust way to create upgrade remaps!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at fixing analogies on upgraded workflows
It should now work through most one-to-one upgrade actions.
The big problem is that right now we do not have a module remapping on upgrade actions. Right now I use the module location to compute upgrade maps, but we may want to find a more robust way to do this.
The algorithm may have problems with some upgrade actions. Right now, upgraded port names are fixed, but function upgrades are not.
Fixes #1175