Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the obsolete material-cab library #1058

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Remove the obsolete material-cab library #1058

wants to merge 27 commits into from

Conversation

soncaokim
Copy link
Collaborator

@soncaokim soncaokim commented Apr 26, 2024 •
edited

To dos:

  • When CAB is shown, the top status bar color turns black (i.e. not the app's primary color)
  • Back navigation needed to leave the CAB mode, even when there is no selected item/no CAB shown
  • go to Album, go to Artist: status bar not in the album/artist palette color

@soncaokim soncaokim changed the title Remove obsolete material-cab library Remove the obsolete material-cab library Apr 26, 2024
@soncaokim soncaokim changed the title Remove the obsolete material-cab library Remove the obsolete material-cab library Apr 26, 2024
@soncaokim soncaokim marked this pull request as ready for review May 17, 2024 15:08
@soncaokim
Replace obsolete com.afollestad:material-cab by std android implement…
004ecbe 
…ation
@soncaokim
Overlay CAB over windows content
4dba4d2
@soncaokim
Override CAB close button
4929586
@soncaokim
Remove todo tag
ab84dc0
@soncaokim
Annotationb
3382f66
@soncaokim
Annotation
fa8721f
@soncaokim
Cleanup theme's action bar, replaced by action mode
fb3ac19
@soncaokim
Fix the bug where a double back nav is needed to exit the CAB mode
9740bd9
@soncaokim
Fix crasher (introduced by the previous commit)
56f0b14
@soncaokim
Simplify
a068de7
@soncaokim
Dont need to use delayed action to decorate the CAB background
4bc6a56
@soncaokim
Null check
16f69ff
@soncaokim
Minor change
081f83b
@soncaokim
Refactoring: Reduce indirection, use directly the native ActionMode c…
1541155 
…oncept
@soncaokim
Refactoring: Move status bar coloring to common class, reduce code dupe
bf9c88f
@soncaokim
Refactoring: Reduce passing action mode background color around
11dd251
@soncaokim
Refactoring: Minor change
3d157ff
@soncaokim
Refactoring: Change the AbsMultiSelectActionModeHolder interface
60ae887
@soncaokim
Refactoring: Move AbsMultiSelectActionModeHolder interface into AbsMu…
2a3e9ad 
…ltiSelectAdapter
@soncaokim
Refactoring: Simplify, remove ActionModeHolder
12117e8
@soncaokim
Finally fix the status bar color while in action mode, on Lollipop+
e2a86b8
@soncaokim
Finally fix the status bar color while in action mode, on Lollipop+
bc2975a
@soncaokim
Refactoring: Drop dead code
2c69bf4
@soncaokim
Fix status bar color regression on now playing screen
358f7fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrienPoupa AdrienPoupa Awaiting requested review from AdrienPoupa

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@soncaokim