feat(ui): size customization #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+34
to
+35
| const height = randomValue(size * 0.5, size); | ||
| const width = randomValue(size * 0.4, size * 0.75); |
There was a problem hiding this comment.
these values will be set at every render and not only on mount.
could you please use useEffect() to set it please ?
comment: we could do this for isRounded too btw
|
Thanks a lot for your nice contribution, can you apply the suggestions to be able to merge it ? :) |
VincentCATILLON
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
sizeprop to allow for customization of the confetti's height/width ratios. The default value is to offset the latest changes to have the confettis closer resemble what is displayed in the demo.Result
Further customization options available and restores confettis visually to < 1.5.2 versions.
Before (current v.1.5.2 code)
After