Add slot methods to a module instead of the component class itself #2040
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Addressed #2027:
super
What approach did you choose and why?
GeneratedAttributeMethods
, I am choosing the nameGeneratedSlotMethods
self::GeneratedSlotMethods
in theinherited
hook defined byViewComponent::Slotable
, similar to how ActiveRecord creates<model>::GeneratedAttributeMethods
.self::GeneratedSlotMethods
in the same inherited hook<slot>
and<slot>?
methods on the moduleTODO
inherited
hook and not theincluded
hook;ViewComponent::Slotable
is included only once byViewComponent::Base
Anything you want to highlight for special attention from reviewers?
bundle install
, with the goal of installing appraisal (otherwisebundle exec appraisal install
would fail)bundle exec appraisal install
modified the gemfiles and I'm not sure why. I have no experience with appraisal. I imagine I will need to revert these changes, but I'm keeping them on the branch for now since if I revert I can't run tests, and also to ask about it.