Add from to use_helpers to add macro like syntax #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joelhawksley @camertron @Spone it seems Rails main is broken again, I will investigate a fix tomorrow evening |
|
@joelhawksley @boardfish @camertron I know I haven't created an issue and I am mostly looking for any feedback on this, I feel that this makes this api largely more complete and fits its purpose of making the usage of helpers more explicit. 🙏 |
Spone
reviewed
May 30, 2024
docs/guide/helpers.md
Outdated
|
|
||
| ```ruby | ||
| class UserComponent < ViewComponent::Base | ||
| use_helpers :icon, from: IconHelper |
There was a problem hiding this comment.
I guess it would make sense to support the singular form use_helper as well?
There was a problem hiding this comment.
@Spone I have added this recommendation, as it seems like a great fit
|
@joelhawksley any thoughts |
|
@reeganviljoen - @camertron and I think this generally looks good, mind getting CI green? |
|
@joelhawksley I will find time tomorrow to fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
use_helepersis powerful but as @joelhawksley mentioned in #1987So this is my attempt at adding a macro syntax by allowing helpers to be defined from specific helper modules
What approach did you choose and why?
I had two make use of two private methods one for the usage of defining a method from
__vc_original_view_contextor one from a specified module witch requires some more complex meta programming to change the ownership of the method to the component.