Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmui/logs: add markdown support #6292

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

Loori-R
Copy link
Contributor

@Loori-R Loori-R commented May 16, 2024

Describe Your Changes

Add support for markdown format and emoji for the _msg field in the "Group" view.
Add markdown rendering toggle. Disabled by default. Value is stored in localStorage.

before
after

Checklist

The following checks are mandatory:

Copy link
Contributor

@dmitryk-dk dmitryk-dk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zekker6
Copy link
Contributor

zekker6 commented May 16, 2024

Do I understand it correctly that current implementation enables markdown rendering by default and there is no way to disable it?
I'm afraid that there will definitely be use-cases when this will render markdown at places where it was just using *, _ or other special characters in markdown, so it would be great to have a toggle to disable this.

@Loori-R
Copy link
Contributor Author

Loori-R commented May 17, 2024

@zekker6, good idea, I'll add a switch.
Should we disable it by default?

@zekker6
Copy link
Contributor

zekker6 commented May 17, 2024

@zekker6, good idea, I'll add a switch. Should we disable it by default?

From my experience, it's better to disable this by default as most logs do not contain markdown at all.

It would be great if we could enable this by default for the play environment thought (or have some kind of automatic detection logic in place).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants