Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app/vmagent: Add remoteWrite.retryMinInterval and remoteWrite.retryMaxTime flags #6289

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

yorik
Copy link

@yorik yorik commented May 16, 2024

Describe Your Changes

Add RemoteWrite Retry Controls

This PR introduces two new flags to the remote write functionality:

  • remoteWrite.retryMinInterval
  • remoteWrite.retryMaxTime

These flags provide finer control over the retry behavior for remoteWrite operations, allowing users to customize the minimum interval between retries and the maximum duration for retry attempts.

Fixes #5486.

Checklist

  • The following checks are mandatory:

My change adheres VictoriaMetrics contributing guidelines.

Signed-off-by: Yury Akudovich <[email protected]>
@yorik yorik changed the title feat: Add remoteWrite.retryMinInterval and remoteWrite.retryMaxTime flags app/vmagent: Add remoteWrite.retryMinInterval and remoteWrite.retryMaxTime flags May 16, 2024
@yorik yorik changed the title app/vmagent: Add remoteWrite.retryMinInterval and remoteWrite.retryMaxTime flags app/vmagent: Add remoteWrite.retryMinInterval and remoteWrite.retryMaxTime flags May 16, 2024
@zekker6 zekker6 requested review from hagen1778 and f41gh7 May 24, 2024 14:51
Copy link
Contributor

@zekker6 zekker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 58.29%. Comparing base (8aaa828) to head (9bcb9cb).
Report is 759 commits behind head on master.

Current head 9bcb9cb differs from pull request most recent head 4f51846

Please upload reports for the commit 4f51846 to get more accurate results.

Files Patch % Lines
app/vmagent/remotewrite/client.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6289      +/-   ##
==========================================
- Coverage   60.37%   58.29%   -2.09%     
==========================================
  Files         411      609     +198     
  Lines       76609    82840    +6231     
==========================================
+ Hits        46253    48291    +2038     
- Misses      27794    31324    +3530     
- Partials     2562     3225     +663     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vmagent keeps retrying and destroys vminsert and entrance
2 participants