support for aws credential_process #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Issue #40
NOTE:
This code currently has a major flaw in that the password prompt doesn't appear if being run as a credential_process within the awscli command. STDIN is still passed to the process, and login succeeds, but only if the user silently knows that STDIN has been grabbed by Alohomora and is expecting input which is dangerous. A non-stdin method of password input would be required to use this. Given that Im not sure this can be useful, but it was a fun POC none the less.
Also, ignore the changes, I didn't turn off isort or autopep8 in my editor, so it mashed in lots of small fixes in some files.