Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the import and export button #62

Closed
wants to merge 2 commits into from

Conversation

Nathanymous
Copy link
Contributor

Moved the import and export button
Added some margin to the save and defaults button
Fixes #53

Moved the import and export button
Added some margin to the save and defaults button
@Nathanymous Nathanymous added bug Something isn't working enhancement New feature or request labels Jul 2, 2023
@Nathanymous Nathanymous self-assigned this Jul 2, 2023
@Nathanymous Nathanymous linked an issue Jul 2, 2023 that may be closed by this pull request
@Nathanymous Nathanymous marked this pull request as draft July 3, 2023 16:29
@Nathanymous
Copy link
Contributor Author

After a quick discussion we decided that all buttons (Save / Defaults / Import / Export) should become icons with onhovers that explains what it does.

Removed the button text and added icons
Set the onhover text to the former button text
Added CSS to style the button

Only didn't get the import button with the right CSS because this is not a real button, but just a div. Looks like the padding might be the problem there.
@TargetCrafter
Copy link
Collaborator

I had a look at you design, but it doesn't feel right. I did some playing around, and i think the below design might be a better fit:

normal fileMenu

@Nathanymous
Copy link
Contributor Author

I think this design is much better. You can go on and build this.

@Nathanymous
Copy link
Contributor Author

I am deleting this PR since there is still work needed to create this.
When the changes are made and the code is ready I will make a new PR

@Nathanymous Nathanymous deleted the 53-move-import-and-export-buttons branch August 20, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move import and export buttons
2 participants