feat(settings): OptionType.ARRAY | OptionType.REGEX #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
1 task
1 task
|
Any update on this? |
|
this is very stale now and i don't quite see the use case for wanting to store maps or regexes. those would better be stored in indexeddb. it seems a bit overengineered to need this serialisation step instead of just continuing to use basic json as for arrays, definitely useful but better implemented like described in #2210 thanks for your efforts regardless <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #615
Adds future support for "impure" types (types aren't JSON values). Right now it adds Arrays, RegExps, and Maps; the example impl is a TextReplace plugin. Not sure what use-case map could have, but I added it before so bleh.
TODO: