Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] ReplaceGoogleSearch #2450

Merged
merged 9 commits into from May 17, 2024
Merged

Conversation

ImpishMoxxie
Copy link
Contributor

ReplaceGoogleSearch

This plugin implements a patch to replace the "Search with Google" in the context menu when right clicking on a highlighted word. You can this engine with the dropdown menu in the settings which gives you the options Google, Bing, Yahoo, Github, Kagi, Yandex, AOL, Baidu and Wikipedia. Alternatively, you can enable the "Use Custom Search Engine" option in the settings to use an alternate engine.

Screenshots

@Vendicated
Copy link
Owner

why not entirely replace the menu and allow multiple options?
image

@ethan-davies
Copy link

Okay, we just replace the old button so you now have a list of options. You can still add your own custom engine using the plugin settings.


@ImpishMoxxie ImpishMoxxie changed the title feat(plugin): ReplaceGoogleSearch [Plugin] ReplaceGoogleSearch May 13, 2024
Copy link
Owner

@Vendicated Vendicated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good! maybe the custom option should be on top?

src/plugins/ReplaceGoogleSearch/index.tsx Outdated Show resolved Hide resolved
src/plugins/ReplaceGoogleSearch/index.tsx Outdated Show resolved Hide resolved
src/plugins/ReplaceGoogleSearch/index.tsx Outdated Show resolved Hide resolved
src/plugins/ReplaceGoogleSearch/index.tsx Outdated Show resolved Hide resolved
src/plugins/ReplaceGoogleSearch/index.tsx Outdated Show resolved Hide resolved
src/plugins/ReplaceGoogleSearch/index.tsx Outdated Show resolved Hide resolved
src/plugins/ReplaceGoogleSearch/index.tsx Outdated Show resolved Hide resolved
@Golonchy
Copy link

merge needed

@ImpishMoxxie
Copy link
Contributor Author

@Golonchy I'll finish working on it today when I'll get home in a few hours or so

@Golonchy
Copy link

alright 👍

@ImpishMoxxie
Copy link
Contributor Author

@Vendicated all updates that you asked got implemented!

src/plugins/ReplaceGoogleSearch/index.tsx Outdated Show resolved Hide resolved
src/plugins/ReplaceGoogleSearch/index.tsx Outdated Show resolved Hide resolved
src/plugins/ReplaceGoogleSearch/index.tsx Show resolved Hide resolved
src/plugins/ReplaceGoogleSearch/index.tsx Show resolved Hide resolved
src/plugins/ReplaceGoogleSearch/index.tsx Outdated Show resolved Hide resolved
@ImpishMoxxie
Copy link
Contributor Author

changed all that was asked @Nuckyz

@ImpishMoxxie ImpishMoxxie requested a review from Nuckyz May 17, 2024 07:02
@Nuckyz Nuckyz changed the base branch from main to dev May 17, 2024 07:14
@Nuckyz Nuckyz merged commit ffe1d7c into Vendicated:dev May 17, 2024
1 check passed
@Nuckyz
Copy link
Collaborator

Nuckyz commented May 17, 2024

Thanks for the new plugin!

LunaisLazier pushed a commit to LunaisLazier/Mooncord that referenced this pull request May 21, 2024
ImLvna pushed a commit to ImLvna/Vencord that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants