✨ isValidERC6492SignatureNow #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@Agusx1211
Closes #940.
On optimization:
It's ok even if the bytes are out-of-bounds in the
signature. Either subsequentmloads will go out-of-gas, or the signature verification will just fail. If there is ever a case where the byte offsets can be manipulated to make the verification pass, it means that the relevant information to make the verification pass is already publicly available on-chain -- anyone can submit a signature that will make the verification pass, even if we have all the bounds checks in place.So what about gas-griefing? Well, the factory address is dynamic anyways...
Letting this marinate for a while.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge snapshot?forge test?Pull requests with an incomplete checklist will be thrown out.